Perex: 1 revision

2019-11-25T10:53:30Z

1 revision

← Older revision	Revision as of 10:53, 25 November 2019
(No difference)

Perex at 10:53, 25 November 2019

2019-11-25T10:53:30Z

New page

{| align="right"
| __TOC__
|}
=Detailed changelog between 1.2.1 and 1.2.1.1 releases=
=Changelog between 1.2.1 and 1.2.1.1 releases=
==alsa-lib==
===Core===
- Release v1.2.1.1
<code>
===PCM API===
- pcm: add braces to condition (coverity)
<code>
===Use Case Manager API===
- ucm: quick fix for the previous commit when ALSA_CONFIG_UCM_VAR is set
<code>
- ucm: fix again the long name configuration filename lookup
<code>
<code>
The fix in commit 77119d83a1f4 assumes that both ucm1 / ucm2 directories
have the configurations for the long name in the same directory. For v2
we changed the location to card_name/card_long_name aka
driver_name/driver_long_name to make the directory layout more structured.
</code>
- ucm: parser: Fix snprintf usage
<code>
<code>
There is no need to manually 0 terminate the buffer with snprintf,
only strncpy has the very unfortunate behavior of not guaranteeing 0
termination.

Likewise there is no need to substract one from the buffer size of
the buffer passed to snprintf.</code>
- ucm: Only look in ucm[1] or ucm2 dir once we've found a config file in one
<code>
<code>
Unless environment variables are set, then configuration_filename()
when initially called by load_master_config() will first try to find
the requested master-config under <prefix>/alsa/ucm2 and then under
<prefix>/alsa/ucm.

Once a master-config is found this way, we should set conf_format to
match, so that subsequent lookups only look under the same directory
as where the master-config was found.

This fixes 2 problems:
1. uc_mgr_config_load() looking under <prefix>/alsa/ucm for includes for
UCM2 profiles because it is called with uc_mgr->conf_format as format
and before this commit that would stay 0 when autodetecion is used.

2. parse_verb_file() possibly loading an UCM2 verb-file for an UCM1 profile,
the chance of this happening is small as this means that even though
there is no UCM2 master-config there is an UCM2 profile dir matching
uc_mgr->conf_file_name, which would be weird.</code>
- ucm: Fix fallback to card_name (shortname) config for ucm1 profiles
<code>
<code>
uc_mgr_import_master_config() first calls load_master_config()
with the card's longname and if that fails then calls it again with the
card_name.

Before this commit configuration_filename() would force conf_format to 2
when it the access(fn, R_OK) test failed for the ucm1 longname
master-config filename.

This would cause configuration_filename() to blindly return a filename
under <prefix>/ucm2 without seeing if that is actually there and without
trying to fallback to the old profiles under <prefix>/ucm, breaking the
loading of UCM1 profiles by card_name.

This commit fixes this by modifying configuration_filename() to not set
conf_format when checking for the UCM1 config filename fails.
Instead, to make sure that any errors about opening the file still report
the new path, configuration_filename() now resets the filename to the UCM2
path if the access() check has failed for both the UCM2 and UCM1 paths,
without touching conf_format.</code>
- ucm: Fix opening of master-configs by the card's longname
<code>
<code>
Prior to commit aba2260ae7b5 ("ucm: switch to ucm2 directory and v2 format,
keep backward compatibility").

The filename build in parse_verb_file() was build like this:
<prefix>/<uc_mgr->conf_file_name>/<file>

Where uc_mgr->conf_file_name would contain either the card_name or the
card's longname depending on the detection of a longname based config in
uc_mgr_import_master_config().

While the filename used in load_master_config() was build like this:
<prefix>/<card_name>/<card_name>.conf

And uc_mgr_import_master_config() first calls load_master_config()
with the card's longname and if that succeeds it overwrites
uc_mgr->conf_file_name with the longname so that the subsequent uses
of uc_mgr->conf_file_name in parse_verb_file() correctly use the longname.

But the new configuration_filename() helper added in commit aba2260ae7b5
_always_ builds the filename like this:
<prefix>/<uc_mgr->conf_file_name>/<file><suffix>

This breaks the loading of the master-config by its longname, as when
the longname is tried uc_mgr->conf_file_name still contains the card_name.

This commit fixes this by adding a dir parameter to configuration_filename()
and restoring the old behavior by passing card_name as dir in
load_master_config().</code>
- ucm: fix memory leaks detected by the coverity checker
<code>
===Configuration===
- conf: check for include path duplicates
<code>
- conf: fix the include paths support
<code>
<code>
I omitted to use parent paths and the proper error code
when no paths are defined.
</code>

Detailed changes v1.2.1 v1.2.1.1 - Revision history

Perex: 1 revision

Perex at 10:53, 25 November 2019