Perex at 16:43, 19 February 2020

2020-02-19T16:43:18Z

New page

{| align="right"
| __TOC__
|}
=Detailed changelog between 1.2.1.2 and 1.2.2 releases=
=Changelog between 1.1.7 and 1.2.2 releases=
==alsa-lib==
===Core===
- Release v1.2.2
<code>
- github build.yml: cosmetic changes
<code>
- github: create test workflow for fedora and ubuntu
<code>
- do not set close-on-exec flag on descriptor if it was already set
<code>
<code>
There is no need to set this again if O_CLOEXEC is supported.</code>
- configure.ac: remove an unnecessary libtool fix
<code>
<code>
This code was added in commit 75d393a563efb578c79364a277087c6326267f52
without explaining why. I assume it was a mistake, since it looks like
the libtool problem should have gone away a long time ago. The referenced
wiki page https://wiki.debian.org/RpathIssue says:

Since libtool 1.5.2 (released 2004-01-25), on Linux libtool no
longer sets RPATH for any directories in the dynamic linker search
path, so this should no longer be an issue unless upstream used a
really old version of libtool when creating their distribution
tarball.

This code caused problems in OpenEmbedded, where the libtool script is
named "x86_64-oe-linux-libtool" or similar rather than just "libtool",
so the sed command failed with a file not found error. Rather than
adapting the code to OpenEmbedded's peculiarities, it seems best to just
remove the unnecessary code altogether.

Note: The rpath is set (hardcoded) for 'make' but it is corrected
for 'make install' by libtool.</code>
- Update the attributes.m4 macro file from xine
<code>
<code>
This file was imported from the xine project. Update it to the current
revision, which resolves the "no AC_LANG_SOURCE call detected in body"
warnings with Autoconf 2.68 or later.</code>
- Fix alsa/sound/*.h for external programs
<code>
<code>
The recent update of sound/*.h to sync with the latest Linus uapi
files broke the build of alsa-tools programs. These files used to be
a modified version of Linux sound/* header files, so that they could
be built without Linux headers. The special prefix like __user and
other things were worked around there.

We may do that again, but a better approach is to fix those things in
Linux kernel uapi side, while we keep the minimal workaround in
alsa-lib such as the __u16 and co type definitions.

This patch is such an attempt, namely:
- Keep the original $LINUX/uapi/sound/*.h in include/sound/uapi
directory
- The "fixes" are applied to some uapi headers, so that they don't
contain Linux-specific prefix and use of opaque struct like
snd_ctl_elem_id
- The uapi headers are included indirectly from include/sound/*.h
- Some headers have inclusion of type_compat.h for the Linux variable
types and prefixes
- type_compat.h tries to use <linux/types.h> when __linux__ is
defined, instead of the own conflicting definitions

The last type might need a bit more adjustment depending on the
compiler, but it can be fixed locally without disturbing else.</code>
===Control API===
- control: Remove access to the deprecated dimen fields
<code>
<code>
The dimen fields of control element has been deprecated, and it's
finally dropped in kernel 5.6 ABI definition. Remove the
corresponding accesses in alsa-lib code.

As of this patch, it's disabled via ifdef, just to be sure. The
disabled code should be removed in a later stage as a cleanup.</code>
- namehint: improve the previous patch (check the returned value)
<code>
- namehint: correct the @args check
<code>
<code>
BugLink: https://github.com/alsa-project/alsa-plugins/issues/3</code>
===Mixer API===
- mixer: Fix memory leak for more than 16 file descriptor case
<code>
===Topology API===
- topology: Drop SNDRV_CTL_ELEM_ACCESS_TIMESTAMP access
<code>
<code>
SNDRV_CTL_ELEM_ACCESS_TIMESTAMP is removed from 5.6 kernel ABI as the
ctl timestamp field has been never used and deprecated.
Drop the corresponding access from the topology code, too.</code>
- topology: remove MAX_FILE definition and use correct PATH_MAX
<code>
- topology: cosmetic changes (functions)
<code>
- topology: tplg_dbg() cleanups
<code>
<code>
- remove newline at the end</code>
- topology: unify the log mechanism
<code>
- topology: move the elem->list delete to tplg_elem_free()
<code>
<code>
The tplg_elem_free() is called in the error path from many places
and it is expected that the element object will be unregistered
from the tplg structure, too.</code>
- topology: implement snd_tplg_decode
<code>
- topology: fix the wrong memory access (object realloc)
<code>
- topology: fix the ops parser (accept integer/hexa values)
<code>
- topology: fix the TPLG_DEBUG compilation
<code>
- topology: implement shorter hexa uuid 00:00 parser
<code>
- topology: fix the unitialized tuples
<code>
- topology: dapm - fix the SNDERR() - Undefined
<code>
- topology: cleanup the SNDERR() calls
<code>
<code>
- remove the wrong new lines
- remove error/warning prefixes (error is error)</code>
- topology: add snd_tplg_version() function
<code>
- topology: add snd_tplg_create() with flags
<code>
<code>
Add SND_TPLG_CREATE_VERBOSE and SND_TPLG_CREATE_DAPM_NOSORT
flags for the special operations.</code>
- topology: add snd_tplg_save()
<code>
- topology: add parser to the tplg_table
<code>
- topology: move the topology element table from builder to elem
<code>
<code>
- use offsetof() for the lists
- add other info to describe the elements
- use the table in the element constructor</code>
- topology: add snd_tplg_load() remove snd_tplg_build_bin_file()
<code>
- topology: parser - recode tplg_parse_config()
<code>
- topology: add binary output from the builder
<code>
<code>
- snd_tplg_build_bin()
- snd_tplg_build_bin_file()</code>
- topology: convert builder to use the mallocated memory
<code>
- topology: add tplg_get_unsigned() function
<code>
- topology: fix tplg_get_integer() - handle errno == ERANGE
<code>
- topology: use snd_config_get_bool() instead own implementation
<code>
- topology: avoid to use the atoi() directly when expected
<code>
- Fix alsa/sound/*.h for external programs
<code>
<code>
The recent update of sound/*.h to sync with the latest Linus uapi
files broke the build of alsa-tools programs. These files used to be
a modified version of Linux sound/* header files, so that they could
be built without Linux headers. The special prefix like __user and
other things were worked around there.

We may do that again, but a better approach is to fix those things in
Linux kernel uapi side, while we keep the minimal workaround in
alsa-lib such as the __u16 and co type definitions.

This patch is such an attempt, namely:
- Keep the original $LINUX/uapi/sound/*.h in include/sound/uapi
directory
- The "fixes" are applied to some uapi headers, so that they don't
contain Linux-specific prefix and use of opaque struct like
snd_ctl_elem_id
- The uapi headers are included indirectly from include/sound/*.h
- Some headers have inclusion of type_compat.h for the Linux variable
types and prefixes
- type_compat.h tries to use <linux/types.h> when __linux__ is
defined, instead of the own conflicting definitions

The last type might need a bit more adjustment depending on the
compiler, but it can be fixed locally without disturbing else.</code>
- topology: more coding fixes
<code>
- topology: dapm - merge identical index blocks like for other elems
<code>
- topology: dapm - coding fixes
<code>
- topology: use list_insert() macro in tplg_elem_insert()
<code>
- topology: make vebose output more nice
<code>
- topology: merge write_block to tplg_write_data
<code>
- topology: use size_t for calc_block_size()
<code>
- topology: use an array describing blocks for the main build loop
<code>
- topology: file position and size cleanups
<code>
<code>
- try to use size_t/ssize_t
- track the position in own variable, do not use lseek</code>
- topology: remove vendor_fd/name from snd_tplg structure - not used
<code>
===Use Case Manager API===
- ucm: parser - add error message to verb_dev_list_add()
<code>
- ucm: fill missing device entries (conflicting / supported)
<code>
<code>
It is not necessary to maintain this information in sync in the configuration
files. Fill the missing entries to the complementary devices.</code>
- ucm: implement RenameDevice and RemoveDevice verb management
<code>
<code>
With the conditionals, it may be useful to define the devices
in the included configuration files. To satisfy the specification
requirements (device naming) those device names might require
to be renamed or deleted wrong references from the conflicting
or supported lists.</code>
- ucm: the ucm2/ subdirectory is driver name based
<code>
- ucm: parser - use correct filename in parser_master_file()
<code>
- ucm: parser - cosmetic fixes in the comments
<code>
- ucm: remove MAX_FILE definition and use correct PATH_MAX
<code>
- ucm: split conf_file_name and conf_dir_name
<code>
<code>
With ucm2, the file name might differ from the directory
name. Also, allocate those fields.</code>
- ucm: fix the configuration directory (longname) for ucm2
<code>
<code>
The new ucm2 expects that the longname directory is shared with
the driver directory. Fix that for 'Syntax 2'.</code>
- ucm: setup conf_format after getting ALSA_CONFIG_UCM_VAR successfully
<code>
<code>
Set the conf_format to 1 after getting ALSA_CONFIG_UCM_VAR successfully.
Otherwise, the conf_format is not set in this scenario.</code>
- ucm: docs - remove MixerCopy values, add Priority for verb, improve priority docs
<code>
- ucm: docs - add note about the sequences and device split
<code>
- ucm: docs - change the Mic description to simple Microphone Device
<code>
- ucm: docs - remove DigitalMic, it does not have sense
<code>
- ucm: docs - add Mic/DigitalMic and multiple devices comments
<code>
- src/ucm/main.c: fix build without mixer
<code>
<code>
Commit 4ce38a5ff466d18039b2606938f866ea3a6c9f3c breaks the build without
mixer on:

CCLD libasound.la
/home/buildroot/autobuild/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/8.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: ucm/.libs/libucm.a(main.o): in function `snd_use_case_set':
main.c:(.text+0x185c): undefined reference to `snd_mixer_selem_id_parse'
</code>
- ucm: Do not fail to parse configs on cards with an empty CardComponents lists
<code>
<code>
Since the UCM profiles for all Bay- and Cherry-Trail SST cards have been
moved over to UCM2, parsing them fails with:

ALSA lib ucm_subs.c:220:(uc_mgr_get_substituted_value) variable '${CardComponents}' is not defined in this context!

This completely breaks audio support on all Bay- and Cherry-Trail devices.

This is caused by these non-SOF ASoC using cards having an empty
CardComponents list. Which in itself is fine, but is rejected by
the ucm_subs.c code. This commit changes the ucm_subs code to accept
an empty string as a valid value for CardComponents restoring audio
functionality on these boards.</code>
- ucm: docs - add JackCTL, rearrange JackControl and JackDev
<code>
- use-case: docs - add PlaybackMixerCopy and CaptureMixerCopy
<code>
- ucm: docs - allow spaces in device names for JackHWMute
<code>
- ucm: add _identifiers list
<code>
- ucm: return always at least NULL if no list is available in snd_use_case_get_list()
<code>
- ucm: Use strncmp to avoid access-out-of-boundary
<code>
<code>
If the length of the identifier is less than the length of the prefix,
access-out-of-boundary will occur in memcmp().</code>
===Configuration===
- Quote strings containing [ or ] when saving an alsa config
<code>
- topology: add snd_tplg_save()
<code>
- alsa-lib: fix the array parser (unique compound keys)
<code>
<code>
The code from the old import may merge arrays wrongly and
the result is a compound with same keys like:

Input:

lines [
"SSP0.OUT, , BUF1.3"
]
lines [
"BUF2.0, , SSP0.IN"
]

Parsed contents:

lines {
0 'SSP0.OUT, , BUF1.3'
0 'BUF2.0, , SSP0.IN'
}

Proper parsed contents (create+merge mode):

lines {
0 'SSP0.OUT, , BUF1.3'
1 'BUF2.0, , SSP0.IN'
}</code>
===Documentation===
- README.md: add build status badge
<code>
===Kernel Headers===
- uapi: Sync with 5.6 kernel ABI
<code>
<code>
This is a sync with 5.6-rc1 kernel headers. The copy is performed
from the sanitized headers installed via make headers_install.</code>
- uapi: Move typedefs from uapi to sound/*
<code>
<code>
For keeping uapi/*.h cleaner.</code>
- type_compat: Add missing __s64 and __u64 definitions for non-Linux
<code>
<code>
Just for the case without Linux-compatible definitions.</code>
- Fix alsa/sound/*.h for external programs
<code>
<code>
The recent update of sound/*.h to sync with the latest Linus uapi
files broke the build of alsa-tools programs. These files used to be
a modified version of Linux sound/* header files, so that they could
be built without Linux headers. The special prefix like __user and
other things were worked around there.

We may do that again, but a better approach is to fix those things in
Linux kernel uapi side, while we keep the minimal workaround in
alsa-lib such as the __u16 and co type definitions.

This patch is such an attempt, namely:
- Keep the original $LINUX/uapi/sound/*.h in include/sound/uapi
directory
- The "fixes" are applied to some uapi headers, so that they don't
contain Linux-specific prefix and use of opaque struct like
snd_ctl_elem_id
- The uapi headers are included indirectly from include/sound/*.h
- Some headers have inclusion of type_compat.h for the Linux variable
types and prefixes
- type_compat.h tries to use <linux/types.h> when __linux__ is
defined, instead of the own conflicting definitions

The last type might need a bit more adjustment depending on the
compiler, but it can be fixed locally without disturbing else.</code>
===Utils===
- alsa.m4: another fix to not link all binaries with -latopology
<code>
<code>
Preserve LIBS when the -latopology is tested. It's added later.</code>
- alsa.m4: another try to fix the libatopology detection
<code>
==alsa-ucm-conf==
===Core===
- github: create validate workflow
<code>
===Configuration===
- broadwell-rt286: more conformance and other fixes
<code>
<code>
Remove JackHWMute, because the hardware does not forcibly shut off
the internal speakers or microphone when the jack is in use.

The CaptureMixerElem and CaptureMasterElem devices were swapped. Do
not manually set the "ADC0 Capture Switch" when disabling a capture
device; it will be set automatically instead.

Correct "Handset" to "Headset". Apply maximum gain to the headset
microphone ("AMIC Volume") when in use, based on testing.</code>
- ucm2: treewide - remove Playback and Capture channels=2 assignments
<code>
<code>
The value 2 is the default.</code>
- sof-hda-dsp: corrections and fixes
<code>
- bytcht-es8316: corrections and fixes
<code>
- bytcr-rt5640: corrections and fixes
<code>
- kblrt5660: corrections and fixes
<code>
- PandaBoardES: corrections and fixes
<code>
- PandaBoard: corrections and fixes
<code>
- SDP4430: corrections and fixes
<code>
- PAZ00: corrections and fixes
<code>
- GoogleNyan: corrections and fixes
<code>
- chtrt5645: corrections and fixes
<code>
- SDP4430: corrections and fixes
<code>
- VEYRON-I2S: corrections and fixes
<code>
- GoogleNyan: comment CaptureControl, what is this?
<code>
- broadwell-rt286: add correct prefix to Priority field names
<code>
- sof-hda-dsp: fix typo (PlaybackMixerMaster -> PlaybackMasterElem)
<code>
- SDP4430: corrections and fixes
<code>
- skylake-rt286: fixes and corrections
<code>
- chtnau8824: fixes and corrections
<code>
- cht-bsw-rt5672: fixes and corrections
<code>
- HDA-Intel/HiFi-dual: fixes and corrections
<code>
- Dell-WD15-Dock: cleaups and corrections
<code>
- DB820c: cleanups and corrections
<code>
- DB410c: cleanups and corrections
<code>
- DAISY-I2S: added back PCM devices
<code>
- bytcht-es8316: cleanups and corrections
<code>
- bytcht-cx2072x: cleanups and corrections
<code>
- bytcr-rt5651: cleanups and corrections
<code>
- bytcr-rt5640: cleanups and corrections
<code>
- broxton-rt298: corrections, cleanups
<code>
- broadwell-rt286: add support for hardware volume, conformance fixes
<code>
- ucm2: fix the verb path in chtrt5645/chtrt5645-dmic2.conf
<code>
- bytcht-es8316: Fix missing including of HeadPhones.conf after ucm2 conversion
<code>
<code>
The conversion to ucm2 format missed adding an include for:

codecs/es8316/HeadPhones.conf

Leading to no sound on the headphones output, this commit adds the missing
include fixing this.</code>
- sof-hda-dsp: Use more strict names according latest use-case.h
<code>
<code>
Also remove ConflictinDevice section from the digital microphone.
Those paths are independent.

BugLink: https://github.com/alsa-project/alsa-ucm-conf/pull/7</code>
- sof-hda-dsp: Fix the Dmic0 CaptureMixerElem for v1.4.1 firmware
<code>
===Description===
- README.md: add build status badge
<code>
- README: remove topologies note
<code>
=Detailed changelog between 1.1.8 and 1.2.2 releases=
=Changelog between 1.1.7 and 1.2.2 releases=
==tinycompress==
===Core===
- Release v1.2.2
<code>
- fcplay: initial addition
<code>
<code>
This tool was forked from tinycompress cplay. The fork was required due
to this linking against libavcodec which is GPL. This uses libav APIs to
parse the compressed files and send the audio stream to compressed
device using tinycompress APIs

Right now it supports only playback on MP3 (no problems now not finding
sync word) and flac files.

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org></code>
- tinycompress: Add pc file
<code>
<code>
Add pc file for the users of this lib</code>
===/Makefile.am===
- tinycompress: Add pc file
<code>
<code>
Add pc file for the users of this lib</code>
===/src/utils-lgpl/Makefile.am===
- fcplay: initial addition
<code>
<code>
This tool was forked from tinycompress cplay. The fork was required due
to this linking against libavcodec which is GPL. This uses libav APIs to
parse the compressed files and send the audio stream to compressed
device using tinycompress APIs

Right now it supports only playback on MP3 (no problems now not finding
sync word) and flac files.

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org></code>
===Header files===
- sound: update header for FLAC
<code>
===Utilities===
- fcplay: initial addition
<code>
<code>
This tool was forked from tinycompress cplay. The fork was required due
to this linking against libavcodec which is GPL. This uses libav APIs to
parse the compressed files and send the audio stream to compressed
device using tinycompress APIs

Right now it supports only playback on MP3 (no problems now not finding
sync word) and flac files.

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org></code>
===pkg-config===
- tinycompress: Add pc file
<code>
<code>
Add pc file for the users of this lib</code>
=Detailed changelog between 1.2.1 and 1.2.2 releases=
=Changelog between 1.1.7 and 1.2.2 releases=
==alsa-utils==
===Core===
- Release v1.2.2
<code>
- configure: fix the inverted libatopology check
<code>
- github workflow: try to fix the empty version
<code>
- github build.yml: try to fix the tag fetch issue (private working dirs)
<code>
- README.md: add build status badge
<code>
- github: create test workflow for fedora and ubuntu
<code>
- configure: fix new libatopology check
<code>
- configure: Fix linking of alsatplg with the older libs
<code>
<code>
BugLink: https://github.com/alsa-project/alsa-utils/issues/33</code>
===ALSA Control (alsactl)===
- Use %lli for long long in printf
<code>
<code>
The `L` length modifier only applies to floating-point conversion
specifiers, and `ll` is used for `long long` integers.

Although glibc accepts %Li, musl does not and returns EINVAL.</code>
- Use __func__ instead of __FUNCTION__
<code>
<code>
They are equivalent, but __func__ is in C99. __FUNCTION__ exists only
for backwards compatibility with old gcc versions.

Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp></code>
- alsactl: fix --sched-idle (set it really to SCHED_IDLE)
<code>
- alsactl: sysfs - add /sys/kernel/uevent_seqnum check to init
<code>
- treewide: Fix printf formats
<code>
<code>
Found with cppcheck</code>
===ALSA RawMidi Utility (amidi)===
- Avoid empty initializer list
<code>
<code>
To zero-initialize an object, use `{0}` instead.</code>
- treewide: sys/poll to poll
<code>
<code>
Fixes warning on musl:

warning redirecting incorrect #include <sys/poll.h> to <poll.h></code>
===Audio Transfer utility===
- Avoid pointer arithmetic on `void *`
<code>
<code>
The pointer operand to the binary `+` operator must be to a complete
object type.</code>
- treewide: Fix wrong formats on 32-bit
<code>
<code>
uint64_t evaluates to unsigned long long on 32-bit, not unsigned long.
Use the proper formats.</code>
===alsa-info.sh===
- alsa-info.sh: Warn after actual upload failure; do not ping server
<code>
<code>
Check the return value of wget to determine if the upload actually
failed. If so, display the message about upload failure, then exit.

Do not ping the web server; the result does not indicate whether a
file upload will succeed or not.</code>
- alsa-info.sh: Perform test for wget earlier
<code>
<code>
If wget is not present, do not ask about uploading the information.</code>
- alsa-info.sh: Condense nested commands for formatting upload result
<code>
- alsa-info.sh: Condense nested commands for file upload
<code>
- alsa-info.sh: Remove progress spinner during upload without dialog
<code>
<code>
The spinner did not actually provide information about the status
of the file upload, and caused other problems: it would repeatedly
spawn new pgrep processes (without a delay between them), and it
blocked the script if any wget process was running on the system.</code>
- alsa-info.sh: Replace gauge with infobox for upload dialog
<code>
<code>
The gauge did not actually show the upload progress; in fact, the
dialog did not even appear until after the upload was completed.

Use an infobox instead, which will be displayed while wget runs.</code>
- alsa-info.sh: Exit script after writing information to stdout
<code>
<code>
The '--stdout' option is mutually exclusive with uploading the file.</code>
- alsa-info.sh: Use existing function to print ALSA configuration files
<code>
- alsa-info.sh: Simplify iteration over cards when calling amixer
<code>
<code>
Read card names directly from individual procfs files, and pass them
to amixer using the '-c' option.</code>
- alsa-info.sh: Read from /proc/modules and sort the result
<code>
<code>
Sorting the list of loaded modules makes it much easier to compare
two alsa-info.txt files, even if they are both from the same system
(since the order actually changes after each reboot).

lsmod just formats the contents of /proc/modules. After this script
calls lsmod, it strips everything but module names from the output.
This same result can be obtained just as easily by reading directly
from /proc/modules; then there is no need to remove the header line
printed by lsmod before sorting the output.</code>
- alsa-info.sh: Consolidate PCI device output
<code>
<code>
Include numeric IDs and subsystem info in the PCI device output,
without placing them in a separate section.</code>
===alsaloop===
- treewide: Fix printf formats
<code>
<code>
Found with cppcheck</code>
===alsamixer===
- Avoid empty initializer list
<code>
<code>
To zero-initialize an object, use `{0}` instead.</code>
===alsatplg (topology)===
- alsatplg: add documentation for -z,--dapm-nosort (-h)
<code>
- alsatplg: add decode command
<code>
- alsatplg: add -V,--version option
<code>
- alsatplg: rewrite to use the new libatopology functions
<code>
<code>
Add '-u,--dump' operation.
Add '-g,--group' and '-x,--nocheck' modifiers.
Add '-z,--dapm-nosort' modifier.
Allow to operate with stdin/stdout for the file input/output.</code>
- alsatplg: fix another small leak in normalize_config()
<code>
- alsatplg: add -s,--sort and fix memory leaks
<code>
- alsatplg: add -n,--normalize option
<code>
<code>
This function loads and parses the topology file and
saves back the structured output in the alsa-lib's format
without comments.</code>
===alsaucm===
- alsaucm: add usecase.h to noinst_HEADERS for packaging
<code>
- alsaucm: dump - fix the prefixed "
<code>
- alsaucm: add json dump command
<code>
- alsaucm: add text dump command
<code>
- alsaucm: use the first sound card (use case name 'hw:CARDNO') as default
<code>
===amixer===
- Use %lli for long long in printf
<code>
<code>
The `L` length modifier only applies to floating-point conversion
specifiers, and `ll` is used for `long long` integers.

Although glibc accepts %Li, musl does not and returns EINVAL.</code>
- treewide: Fix printf formats
<code>
<code>
Found with cppcheck</code>
- treewide: sys/poll to poll
<code>
<code>
Fixes warning on musl:

warning redirecting incorrect #include <sys/poll.h> to <poll.h></code>
===aplay/arecord===
- Avoid pointer arithmetic on `void *`
<code>
<code>
The pointer operand to the binary `+` operator must be to a complete
object type.</code>
- Use __func__ instead of __FUNCTION__
<code>
<code>
They are equivalent, but __func__ is in C99. __FUNCTION__ exists only
for backwards compatibility with old gcc versions.

Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp></code>
- aplay: Limit VUMeter progress bar to 100 for negative as well
<code>
<code>
While the progress bar cannot be negative, GCC concludes that it can be
and assumes tmp can be written past the end. Fixes this GCC warning:

aplay.c:1747:18: warning: '%02d' directive writing between 2 and 11 bytes
into a region of size 4 [-Wformat-overflow=]
1747 | sprintf(tmp, "%02d%%", maxperc[c]);</code>
- aplay: Adjust buffer sizes to fix snprintf warnings
<code>
<code>
It also reduces compiled size slightly.

aplay.c: In function 'capture':
aplay.c:3055:34: error: '-01' directive output may be truncated writing 3
bytes into a region of size between 1 and 4097 [-Werror=format-truncation=
]
3055 | snprintf(namebuf, namelen, "%s-01", buf);
| ^~~
aplay.c:3055:4: note: 'snprintf' output between 4 and 4100 bytes into a
destination of size 4097
3055 | snprintf(namebuf, namelen, "%s-01", buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
aplay.c:3053:34: error: '-01.' directive output may be truncated writing 4
bytes into a region of size between 1 and 4097 [-Werror=format-truncation=
]
3053 | snprintf(namebuf, namelen, "%s-01.%s", buf, s);
| ^~~~
aplay.c:3053:4: note: 'snprintf' output 5 or more bytes (assuming 4101)
into a destination of size 4097
3053 | snprintf(namebuf, namelen, "%s-01.%s", buf, s);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
aplay.c:3065:34: error: '%02i' directive output may be truncated writing
between 2 and 10 bytes into a region of size between 0 and 4096 [-Werror=
format-truncation=]
3065 | snprintf(namebuf, namelen, "%s-%02i", buf, filecount);
| ^~~~
aplay.c:3065:30: note: directive argument in the range [1, 2147483647]
3065 | snprintf(namebuf, namelen, "%s-%02i", buf, filecount);
| ^~~~~~~~~
aplay.c:3065:3: note: 'snprintf' output between 4 and 4108 bytes into a
destination of size 4097
3065 | snprintf(namebuf, namelen, "%s-%02i", buf, filecount);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
aplay.c:3063:34: error: '%02i' directive output may be truncated writing
between 2 and 10 bytes into a region of size between 0 and 4096 [-Werror=
format-truncation=]
3063 | snprintf(namebuf, namelen, "%s-%02i.%s", buf, filecount, s);
| ^~~~
aplay.c:3063:30: note: directive argument in the range [1, 2147483647]
3063 | snprintf(namebuf, namelen, "%s-%02i.%s", buf, filecount, s);
| ^~~~~~~~~~~~
aplay.c:3063:3: note: 'snprintf' output 5 or more bytes (assuming 4109)
into a destination of size 4097
3063 | snprintf(namebuf, namelen, "%s-%02i.%s", buf, filecount, s);</code>
- treewide: Fix printf formats
<code>
<code>
Found with cppcheck</code>
- treewide: sys/poll to poll
<code>
<code>
Fixes warning on musl:

warning redirecting incorrect #include <sys/poll.h> to <poll.h></code>
===aplaymidi/arecordmidi===
- Avoid empty initializer list
<code>
<code>
To zero-initialize an object, use `{0}` instead.</code>
- treewide: sys/poll to poll
<code>
<code>
Fixes warning on musl:

warning redirecting incorrect #include <sys/poll.h> to <poll.h></code>
===aseqdump===
- Avoid empty initializer list
<code>
<code>
To zero-initialize an object, use `{0}` instead.</code>
===bat (basic audio tester)===
- Avoid pointer arithmetic on `void *`
<code>
<code>
The pointer operand to the binary `+` operator must be to a complete
object type.</code>
==alsa-plugins==
===Core===
- Release v1.2.2
<code>
- Update the attributes.m4 macro file from xine
<code>
<code>
This file was imported from the xine project. Update it to the current
revision, which resolves the "no AC_LANG_SOURCE call detected in body"
warnings with Autoconf 2.68 or later.</code>
===Automatic upmix / downmix plugins===
- upmix: generalize format, code cleanup
<code>
<code>
The main purpose of this change is to be able to change the format to
e.g. S32 instead of S16 by changing only two lines on the top of the source.
So a new symbol UPMIX_PCM_FORMAT is added to hide the actual format,
and a special type upmix_sample_t marks the sample type, instead of
fixed short.

The average_copy function was expecting the nchns parameter to be 2,
this parameter is now a local constant.

The variable i is renamed to channel as it denotes the channel index
in every case.

The behavior of the plugin remains identical.</code>
=Detailed changelog between 1.1.7 and 1.2.2 releases=
=Changelog between 1.1.7 and 1.2.2 releases=
==alsa-tools==
===Core===
- Release v1.2.2
<code>
===hdspmixer===
- hdspmixer: Use __u32 and __u64 for RMS array types
<code>
<code>
Some variable types are referring to the field in ioctl struct, which
are actually __u32 or __u64 instead of uint32_t or uint64_t.
This inconsistency may result in the compile error.</code>

Detailed changes v1.2.1.2 v1.2.2 - Revision history

Perex: 1 revision

Perex at 16:43, 19 February 2020

← Older revision	Revision as of 16:43, 19 February 2020
(No difference)